Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise invalid date for non-200 player box score responses #64

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

jaebradley
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #64 into v4 will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4      #64      +/-   ##
==========================================
+ Coverage   94.16%   94.29%   +0.13%     
==========================================
  Files          10       10              
  Lines         257      263       +6     
  Branches       30       31       +1     
==========================================
+ Hits          242      248       +6     
  Misses         11       11              
  Partials        4        4
Impacted Files Coverage Δ
basketball_reference_web_scraper/http_client.py 100% <100%> (ø) ⬆️
basketball_reference_web_scraper/client.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c8bc8...7dd919b. Read the comment docs.

@jaebradley jaebradley merged commit 45af162 into v4 Nov 28, 2018
@jaebradley jaebradley deleted the player-box-scores/raise-invalid-date-for-404s branch November 28, 2018 04:21
@jaebradley jaebradley mentioned this pull request Nov 28, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant