Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 Features #56

Merged
merged 9 commits into from
Nov 28, 2018
Merged

V4 Features #56

merged 9 commits into from
Nov 28, 2018

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented Nov 22, 2018

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    93.8%   94.16%   +0.36%     
==========================================
  Files          10       10              
  Lines         242      257      +15     
  Branches       27       30       +3     
==========================================
+ Hits          227      242      +15     
  Misses         11       11              
  Partials        4        4
Impacted Files Coverage Δ
basketball_reference_web_scraper/output.py 82.92% <ø> (ø) ⬆️
basketball_reference_web_scraper/data.py 100% <ø> (ø) ⬆️
basketball_reference_web_scraper/errors.py 100% <100%> (ø) ⬆️
basketball_reference_web_scraper/client.py 100% <100%> (ø) ⬆️
...rence_web_scraper/parsers/players_season_totals.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf0a26...8d6826e. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 23, 2018

Codecov Report

Merging #56 into master will increase coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage    93.8%   94.29%   +0.49%     
==========================================
  Files          10       10              
  Lines         242      263      +21     
  Branches       27       31       +4     
==========================================
+ Hits          227      248      +21     
  Misses         11       11              
  Partials        4        4
Impacted Files Coverage Δ
basketball_reference_web_scraper/data.py 100% <ø> (ø) ⬆️
...sketball_reference_web_scraper/parsers/schedule.py 94.11% <ø> (ø) ⬆️
basketball_reference_web_scraper/output.py 82.92% <ø> (ø) ⬆️
setup.py 0% <ø> (ø) ⬆️
basketball_reference_web_scraper/errors.py 100% <100%> (ø) ⬆️
basketball_reference_web_scraper/http_client.py 100% <100%> (ø) ⬆️
basketball_reference_web_scraper/client.py 100% <100%> (ø) ⬆️
...rence_web_scraper/parsers/players_season_totals.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf0a26...bc3a4d1. Read the comment docs.

Add logic so that the schedule scraper can get all the games for
the current season without crashing, leaving scores off of the
returned game hashes

Adds `None` as default values if away team score or home team score are not available
@jaebradley jaebradley merged commit bc3a4d1 into master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants