Improve schedule parser #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add logic so that the schedule scraper can get all the games for the current season without crashing, leaving scores off of the returned game hashes Adds `None` as default values if away team score or home team score are not available
Codecov Report
@@ Coverage Diff @@
## v4 #66 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 10 10
Lines 257 257
Branches 30 30
=======================================
Hits 242 242
Misses 11 11
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61 patched this in V3 but this also needs to get patched in V4.
Add logic so that the schedule scraper can get all the games for
the current season without crashing, leaving scores off of the
returned game hashes
Adds
Noneas default values if away team score or home team score are not available