Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player slug to player box score and player season totals #75

Merged
merged 4 commits into from
Mar 4, 2019

Conversation

jaebradley
Copy link
Owner

@jaebradley jaebradley commented Mar 4, 2019

As #74 pointed out, player box scores and player season totals do not have a unique identifier.

The data-append-csv attribute on a player's name cell should be used - this value is the URI slug for a player's Basketball Reference Page.

image

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #75 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##              v4     #75   +/-   ##
=====================================
  Coverage   92.5%   92.5%           
=====================================
  Files         12      12           
  Lines        307     307           
  Branches      38      38           
=====================================
  Hits         284     284           
  Misses        19      19           
  Partials       4       4
Impacted Files Coverage Δ
...eference_web_scraper/parsers/box_scores/players.py 100% <ø> (ø) ⬆️
...rence_web_scraper/parsers/players_season_totals.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bc06c...2bd9f62. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #75 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##              v4     #75   +/-   ##
=====================================
  Coverage   92.5%   92.5%           
=====================================
  Files         12      12           
  Lines        307     307           
  Branches      38      38           
=====================================
  Hits         284     284           
  Misses        19      19           
  Partials       4       4
Impacted Files Coverage Δ
basketball_reference_web_scraper/output.py 76.59% <ø> (ø) ⬆️
setup.py 0% <ø> (ø) ⬆️
...eference_web_scraper/parsers/box_scores/players.py 100% <ø> (ø) ⬆️
...rence_web_scraper/parsers/players_season_totals.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bc06c...d3d9b08. Read the comment docs.

@jaebradley jaebradley merged commit e178261 into v4 Mar 4, 2019
@jaebradley jaebradley deleted the add-player-slug branch March 4, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant