-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-unique player names? #74
Comments
@bpisaacoff great question! So they don't have a unique identifier per se, but you could use a player's URL (or in the screenshot below, the Would adding such an identifier be useful? |
Yes I think it is a good future proofing method. Thanks! |
As #74 pointed out, player box scores and player season totals do not have a unique identifier. The `data-append-csv` attribute on a player's name cell should be used - this value is the URI slug for a player's Basketball Reference Page. ![image](https://user-images.githubusercontent.com/8136030/53716772-d4112800-3e0a-11e9-9369-6c8e44d6cf97.png)
@bpisaacoff #75 should have been merged and published as |
How are non-unique player names handled? stats.nba.com for example uses a player ID system to avoid this.
The text was updated successfully, but these errors were encountered: