Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-unique player names? #74

Closed
bpisaacoff opened this issue Mar 2, 2019 · 3 comments
Closed

Non-unique player names? #74

bpisaacoff opened this issue Mar 2, 2019 · 3 comments

Comments

@bpisaacoff
Copy link

How are non-unique player names handled? stats.nba.com for example uses a player ID system to avoid this.
@jaebradley
Copy link
Owner

@bpisaacoff great question!

So they don't have a unique identifier per se, but you could use a player's URL (or in the screenshot below, the data-append-csv data attribute) as a unique identifier.

image

Would adding such an identifier be useful?

@bpisaacoff
Copy link
Author

Yes I think it is a good future proofing method. Thanks!

@jaebradley jaebradley mentioned this issue Mar 4, 2019
Merged
jaebradley added a commit that referenced this issue Mar 4, 2019
@jaebradley
Add player slug to player box score and player season totals (#75)
e178261 
As #74 pointed out, player box scores and player season totals do not have a unique identifier.

The `data-append-csv` attribute on a player's name cell should be used - this value is the URI slug for a player's Basketball Reference Page.

![image](https://user-images.githubusercontent.com/8136030/53716772-d4112800-3e0a-11e9-9369-6c8e44d6cf97.png)
@jaebradley
Copy link
Owner

@bpisaacoff #75 should have been merged and published as v4.2.0. It adds a slug field to each output row from player box scores and player season totals tables which represents the URI slug for each player's personal page on Basketball Reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaebradley @bpisaacoff