Adding support to Typescript #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rubens21 <rubens21@gmail.com>
Signed-off-by: rubens21 <rubens21@gmail.com>
rubens21
force-pushed
the
add-typescript-support
branch
from
ab8ea7f
to
368eb91
Compare
Signed-off-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
yurishkuro
reviewed
Jun 29, 2024
| @@ -49,6 +50,10 @@ RUN mkdir -p /grpc-java && \ | |||
| rm -Rf /grpc-java && \ | |||
| rm -Rf /grpc | |||
|
|
|||
| ARG GRPC_WEB_VERSION | |||
| RUN curl -sSLO https://github.com/grpc/grpc-web/releases/download/${GRPC_WEB_VERSION}/protoc-gen-grpc-web-${GRPC_WEB_VERSION}-linux-x86_64 && \ | |||
There was a problem hiding this comment.
@rubens21 we are using a multi-arch build (for amd64 and arm64). I see that at least in v1.5.0 of GPRC_WEB they publish aarch64 build, so if you want to change this to work with both, we could merge.
I would've preferred to have some test. Right now we test the build by running make proto in jaeger-idl, which I think exercises multiple languages. We could include the new TS output there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the plugin grpc-web to support Typescript.
...
Changes
protoc_builderintermediate image with thegrpc-webgRPC pluginRelease Notes