Automate release #252
Merged
Automate release #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
I have done release 1.12 and 1.13 locally to verify if sed commands work |
|
I will remove those commits once this pr is approved |
yurishkuro
approved these changes
May 17, 2019
| fi | ||
| } | ||
|
|
||
| if [[ "$TRAVIS_TAG" =~ ^release-[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+?$ ]]; then |
There was a problem hiding this comment.
Space looks like typo, can say we are on release-..* tag
There was a problem hiding this comment.
which space? I think condition works well.
|
|
||
| set -o errexit -o nounset -o pipefail | ||
|
|
||
| safe_checkout_master() { |
There was a problem hiding this comment.
Is this code copied from somewhere? Feels familiar, we could add attribution comment.
There was a problem hiding this comment.
It's from java client, It is fairly simple code
travis/release.sh
Outdated
|
|
||
| if [[ "$TRAVIS_TAG" =~ ^release-[[:digit:]]+\.[[:digit:]]+\.[[:digit:]]+?$ ]]; then | ||
| echo "We are on release- tag" | ||
| echo "Creating new documentation version" |
There was a problem hiding this comment.
Suggestion: move after L26 and include version in the message
.travis.yml
Outdated
| before_install: | ||
| - git config user.name "jaegertracingci" | ||
| - git config user.email "jaegertracingci+jaeger-tracing@googlegroups.com" | ||
| # setup https authentication credentials, used by ./gradlew publish |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
automate-release
branch
from
7175b32
to
9e272a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #249