Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hugo 0.123.6 & fix related warning and error #675

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

tico88612
Copy link
Contributor

@tico88612 tico88612 commented Mar 2, 2024

Which problem is this PR solving?

Description of the changes

  • Upgrade Hugo latest version (0.123.6)
  • Fix warning Remove deprecated disableKinds taxonomyTerm
  • Fix error .File.Path nil pointer problem
  • Fix warning no layout file for "html" for kind "section"
  • Fix warning hugo verbose deprecated
  • Fix Hugo 0.123.x remove symlink support
  • Fix .Site.IsServer deprecated in Hugo v0.120.0
  • Fix data.GetJSON deprecated in Hugo v0.123.0

FYI

How was this change tested?

  • No, maybe we can discuss

Checklist

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for romantic-neumann-1959d7 ready!

Name Link
🔨 Latest commit d828775
🔍 Latest deploy log https://app.netlify.com/sites/romantic-neumann-1959d7/deploys/65e66d85bbe8080008c76d31
😎 Deploy Preview https://deploy-preview-675--romantic-neumann-1959d7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tico88612 tico88612 mentioned this pull request Mar 2, 2024
Makefile Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/docs/panel.html Outdated Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/docs/header.html Outdated Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/docs/panel.html Outdated Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/navbar.html Outdated Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/navbar.html Outdated Show resolved Hide resolved
themes/jaeger-docs/layouts/partials/search.html Outdated Show resolved Hide resolved
@tico88612 tico88612 force-pushed the feat/upgrade-hugo-0.123.6 branch 2 times, most recently from 5d0ee58 to 349dfa4 Compare March 2, 2024 05:00
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I ran make develop on the PR branch I still got the warning abtot .Path, is there some page you missed?

Makefile Show resolved Hide resolved
@tico88612
Copy link
Contributor Author

tico88612 commented Mar 4, 2024

UPD: 0.120.3 will get the warning message 0.123.6 not.


{{ $version := index (split .Path "/") 1 }}

I would fix it.

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please elaborate why you need a new file themes/jaeger-docs/layouts/_default/section.html

@tico88612
Copy link
Contributor Author

@yurishkuro If there is no such file themes/jaeger-docs/layouts/_default/section.html, a warning message will pop up.

WARN  found no layout file for "html" for kind "section": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.

FYI:

@yurishkuro
Copy link
Member

I am seeing these additional warnings (which are for some reason tagged as INFO, even though they should break in the future):

INFO  deprecated: .Site.IsServer was deprecated in Hugo v0.120.0 and will be removed in a future release. Use hugo.IsServer instead.
INFO  deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in a future release. use resources.Get or resources.GetRemote with transform.Unmarshal.

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612
Copy link
Contributor Author

I am seeing these additional warnings (which are for some reason tagged as INFO, even though they should break in the future):

INFO  deprecated: .Site.IsServer was deprecated in Hugo v0.120.0 and will be removed in a future release. Use hugo.IsServer instead.
INFO  deprecated: data.GetJSON was deprecated in Hugo v0.123.0 and will be removed in a future release. use resources.Get or resources.GetRemote with transform.Unmarshal.

Fixed.

@yurishkuro yurishkuro merged commit 82d6bdf into jaegertracing:main Mar 5, 2024
10 checks passed
@yurishkuro
Copy link
Member

Thanks!

@tico88612 tico88612 deleted the feat/upgrade-hugo-0.123.6 branch March 5, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Hugo warnings
2 participants