Make GuaranteedThroughputSampler public

[quaff]

No description provided.

[codecov]

Codecov Report

Merging #457 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #457     +/-   ##
===========================================
+ Coverage     88.14%   88.25%   +0.1%     
+ Complexity      490      489      -1     
===========================================
  Files            62       62             
  Lines          1848     1847      -1     
  Branches        241      241             
===========================================
+ Hits           1629     1630      +1     
+ Misses          142      139      -3     
- Partials         77       78      +1

Impacted Files	Coverage Δ	Complexity Δ
...internal/samplers/GuaranteedThroughputSampler.java	92.3% <100%> (+3.41%)	7 <1> (ø)	⬇️
...ing/internal/samplers/RemoteControlledSampler.java	89.53% <0%> (-1.17%)	17% <0%> (-1%)
...egertracing/internal/reporters/RemoteReporter.java	85.71% <0%> (+2.38%)	7% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527b1ce...e08e616. Read the comment docs.

[jpkrohling]

@quaff, do you have a reason to require this to be public? Also, looks like your commit is missing the DCO sign-off.

[quaff]

@jpkrohling I have updated this commit, I prefer this Sampler for my application, any concern to make it package access level?

[jpkrohling]

I really don't have any concerns, but we are about to discuss whether those samplers should be part of the public API or not. If you could share your use case, it would certainly help us decide to make this class part of it.

It would be really nice if you could edit this PR description to add your use case.

I'm reviewing this PR as "approved" and will merge as soon as you can share the description above. I'm sure nobody would have any concerns if you can provide such description :)

[jpkrohling]

Just noticed this change here: this exposes a new constructor, to initialize the private fields (probabilisticSampler, lowerBoundSampler and tags).

I don't think we want that. In fact, I think this annotation can be removed altogether.

Dismissing the review, because of the all-args constructor

[quaff]

@jpkrohling commit updated, since ProbabilisticSampler and RateLimitingSampler are public, why not GuaranteedThroughputSampler?

[jpkrohling]

There might be a reason why this is not public. I'll ask about it during our meeting today, but I think nobody will object to merging this.

You are more than welcome to join our meeting today!
https://github.com/jaegertracing/jaeger#project-status-bi-weekly-meeting

[jpkrohling]

@quaff Looks like a recent change caused merge conflicts with this PR. Would you please update it? Once it's rebased to the latest master, I'll merge it.

[quaff]

@jpkrohling updated.

[jpkrohling]

Thanks, @quaff!