You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Is not ideal when running jaeger_client in containerized applications. It seems most useful to allow setting a custom hostname in the config or via an environment variable. We're currently using an init_tracer() like this for flask applications:
* Allow specifying the hostname via a tag
This is useful for applications running inside containers where the
hostname is autogenerated and generally useless. In kubernetes, the
downward api can be used to pass in the node name actually running
the container.
Fixes#66
Signed-off-by: Jeff Schroeder <jeffschroeder@computer.org>
* Catch the `socket.error` exception when trying to get the hostname
This is the base exception for all errors in the socket library. Explicit
is better than implicit!
Signed-off-by: Jeff Schroeder <jeffschroeder@computer.org>
* Don't attempt to lookup the ip address if specified via a tag
This matches the functionality of jaeger-client-java after
jaegertracing/jaeger-client-java#371 was merged.
Refs: #166
Signed-off-by: Jeff Schroeder <jeffschroeder@computer.org>
* Remove ipv4_to_int since jaeger converts tags to strings
Signed-off-by: Jeff Schroeder <jeffschroeder@computer.org>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This code:
jaeger-client-python/jaeger_client/tracer.py
Lines 89 to 90 in 34364d0
Is not ideal when running
jaeger_client
in containerized applications. It seems most useful to allow setting a custom hostname in the config or via an environment variable. We're currently using aninit_tracer()
like this for flask applications:The
NODE_NAME
env var is set via the kubernetes downward api to the actual kubelet running the pod (since it runs a jaeger-agent pod on every node).Changing the code for this seems pretty trivial, but what do you suggest we name the config and env variable for this?
The text was updated successfully, but these errors were encountered: