This repository has been archived by the owner on Jul 11, 2022. It is now read-only.
Add BaggageRestrictionManager #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oibe
reviewed
Aug 11, 2017
|
|
||
| from __future__ import absolute_import | ||
|
|
||
| from .restriction import Restriction # noqa |
oibe
reviewed
Aug 11, 2017
|
|
||
| class Restriction(object): | ||
| """ | ||
| Restriction determines whether a baggage key is allowed and contains any |
There was a problem hiding this comment.
s/any restrictions/any length based restrictions/
Since this restriction object doesn't have code for restricting the value of the key
oibe
reviewed
Aug 11, 2017
| def __init__(self, restriction_manager, metrics_factory): | ||
| self._restriction_manager = restriction_manager | ||
| self._baggage_update_success = \ | ||
| metrics_factory.create_counter(name='jaeger.baggage-update', tags={'result': 'ok'}) |
There was a problem hiding this comment.
Why add the jaeger prefix for python metric names?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.