Include serviceName in tracked events from Search Form (#842)

Signed-off-by: vvvprabhakar <prabhakar.vemparala@freshworks.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
jaegertracing · Mar 4, 2022 · ce9368d · ce9368d
1 parent b4b863b
commit ce9368d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.js
@@ -238,7 +238,7 @@ export function submitForm(fields, searchTraces) {
     end = times.end;
   }
 
-  trackFormInput(resultsLimit, operation, tags, minDuration, maxDuration, lookback);
+  trackFormInput(resultsLimit, operation, tags, minDuration, maxDuration, lookback, service);
 
   searchTraces({
     service,

diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.test.js b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.test.js
@@ -25,6 +25,7 @@ import {
   CATEGORY_OPERATION,
   CATEGORY_SORTBY,
   CATEGORY_TAGS,
+  CATEGORY_SERVICE,
 } from './SearchForm.track';
 import { FORM_CHANGE_ACTION_TYPE } from '../../constants/search-form';
 import { trackEvent } from '../../utils/tracking';
@@ -39,8 +40,8 @@ describe('GA tracking', () => {
 
   it('sends form input to GA', () => {
     trackEvent.mockClear();
-    trackFormInput(0, '', {}, 0, 0, '');
-    expect(trackEvent.mock.calls.length).toBe(6);
+    trackFormInput(0, '', {}, 0, 0, '', '');
+    expect(trackEvent.mock.calls.length).toBe(7);
     const categoriesTracked = trackEvent.mock.calls.map(call => call[0]).sort();
     expect(categoriesTracked).toEqual(
       [
@@ -50,6 +51,7 @@ describe('GA tracking', () => {
         CATEGORY_MAX_DURATION,
         CATEGORY_MIN_DURATION,
         CATEGORY_LOOKBACK,
+        CATEGORY_SERVICE,
       ].sort()
     );
   });

diff --git a/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.tsx b/packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.tsx
@@ -30,21 +30,23 @@ export const CATEGORY_TAGS = `${FORM_CATEGORY_BASE}/tags`;
 export const CATEGORY_MIN_DURATION = `${FORM_CATEGORY_BASE}/min_duration`;
 export const CATEGORY_MAX_DURATION = `${FORM_CATEGORY_BASE}/max_duration`;
 export const CATEGORY_LIMIT = `${FORM_CATEGORY_BASE}/limit`;
-
+export const CATEGORY_SERVICE = `${FORM_CATEGORY_BASE}/serviceName`;
 export function trackFormInput(
   resultsLimit: number,
   operation: string,
   tags: any,
   minDuration: number,
   maxDuration: number,
-  lookback: string
+  lookback: string,
+  serviceName: string
 ) {
   trackEvent(CATEGORY_OPERATION, operation === constants.DEFAULT_OPERATION ? ACTION_DEFAULT : ACTION_SET);
   trackEvent(CATEGORY_LIMIT, resultsLimit === constants.DEFAULT_LIMIT ? ACTION_DEFAULT : ACTION_SET);
   trackEvent(CATEGORY_MAX_DURATION, maxDuration ? ACTION_SET : ACTION_CLEAR);
   trackEvent(CATEGORY_MIN_DURATION, minDuration ? ACTION_SET : ACTION_CLEAR);
   trackEvent(CATEGORY_TAGS, tags ? ACTION_SET : ACTION_CLEAR);
   trackEvent(CATEGORY_LOOKBACK, lookback);
+  trackEvent(CATEGORY_SERVICE, serviceName);
 }
 
 export const middlewareHooks = {