Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Event for Service Name in Search Form #842

Merged
merged 5 commits into from
Mar 4, 2022

Conversation

vvvprabhakar
Copy link
Contributor

@vvvprabhakar vvvprabhakar commented Oct 29, 2021

Signed-off-by: vvvprabhakar prabhakar.vemparala@freshworks.com

Which problem is this PR solving?

Short description of the changes

  • Added serviceName in searchTrackForm
  • Added Track Event for ServiceName in searchForm
  • Added the test case Changes

Signed-off-by: vvvprabhakar <prabhakar.vemparala@freshworks.com>
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #842 (3d8fc8e) into main (b4b863b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #842      +/-   ##
==========================================
+ Coverage   95.33%   95.38%   +0.05%     
==========================================
  Files         240      240              
  Lines        7495     7497       +2     
  Branches     1870     1870              
==========================================
+ Hits         7145     7151       +6     
+ Misses        344      340       -4     
  Partials        6        6              
Impacted Files Coverage Δ
...er-ui/src/components/SearchTracePage/SearchForm.js 92.10% <100.00%> (ø)
...rc/components/SearchTracePage/SearchForm.track.tsx 100.00% <100.00%> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 96.20% <0.00%> (+0.68%) ⬆️
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 100.00% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4b863b...3d8fc8e. Read the comment docs.

@vvvprabhakar vvvprabhakar changed the title serviceName Track Event Track Event for Service Name in Search Form Oct 29, 2021
@yurishkuro yurishkuro enabled auto-merge (squash) November 25, 2021 20:32
@yurishkuro yurishkuro merged commit ce9368d into jaegertracing:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intentional to not have track event for serviceName
2 participants