Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Viewing Layer zoom #215

Closed
yuribit opened this issue Jun 4, 2018 · 2 comments
Closed

Reset Viewing Layer zoom #215

yuribit opened this issue Jun 4, 2018 · 2 comments
Assignees
@everett980
Labels
enhancement help wanted

Comments

@yuribit
Copy link
Contributor

yuribit commented Jun 4, 2018 •
edited
Loading

It would be nice to have a way to reset the selection on the Viewing Layer in the Trace Page Header.
The easiest way to do that could be a "Reset Selection" button right above the Viewing Layer.

Something like this:
example

What do you think?
@yuribit yuribit changed the title [Feature request] Reset Viewing Layer zoom Reset Viewing Layer zoom Jun 15, 2018
@tiffon
Copy link
Member

tiffon commented Jun 16, 2018

@yuribit Thanks for creating this ticket!

Great suggestion. Maybe it can show on mouse-over of the minimap, just below the bottom of the map. That way it won't obscure image or other zoom controls.

everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 11, 2018
@everett980
Add button to reset viewing layer zoom (jaegertracing#215)
47bace4 
Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 11, 2018
@everett980
Add button to reset viewing layer zoom (jaegertracing#215)
63bbc2c 
Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Dec 11, 2018
@everett980
Add button to reset viewing layer zoom (jaegertracing#215)
4940302 
Signed-off-by: Everett Ross <reverett@uber.com>
@everett980 everett980 mentioned this issue Dec 11, 2018
Merged
@everett980 everett980 self-assigned this Dec 13, 2018
everett980 added a commit that referenced this issue Jan 3, 2019
@everett980
Add a Button to Reset Viewing Layer Zoom (#215) (#290)
0a0cf66 
* Add button to reset viewing layer zoom (#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>
everett980 added a commit to everett980/jaeger-ui that referenced this issue Jan 16, 2019
@everett980
Add a Button to Reset Viewing Layer Zoom (jaegertracing#215) (jaegert…
d90d042 
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@tiffon
Copy link
Member

tiffon commented Mar 24, 2019 •
edited
Loading

This was fixed in #290 (although there is a regression where the minimap dragging is not working, at the moment – #354).

@tiffon tiffon closed this as completed Mar 24, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@everett980
Add a Button to Reset Viewing Layer Zoom (jaegertracing#215) (jaegert…
6cf9ac0 
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@everett980
Add a Button to Reset Viewing Layer Zoom (jaegertracing#215) (jaegert…
11c94ea 
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@everett980 everett980

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuribit @tiffon @everett980