Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Button to Reset Viewing Layer Zoom (#215) #290

Merged

Conversation

everett980
Copy link
Collaborator

@everett980 everett980 commented Dec 11, 2018

Which problem is this PR solving?

Short description of the changes

  • Renders a button when either scrubber is not at the appropriate extreme.
  • Button is hidden unless user mouses over the timeline.
  • On click, resets viewing layer zoom back to fully zoomed out, both scrubbers back to appropriate extreme.

reset selection webm

Signed-off-by: Everett Ross <reverett@uber.com>
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   82.19%   82.19%   +<.01%     
==========================================
  Files         141      141              
  Lines        3100     3101       +1     
  Branches      645      645              
==========================================
+ Hits         2548     2549       +1     
  Misses        438      438              
  Partials      114      114
Impacted Files Coverage Δ
...racePage/TracePageHeader/SpanGraph/ViewingLayer.js 92.95% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab69885...d440970. Read the comment docs.

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, couple of minor questions.

Signed-off-by: Everett Ross <reverett@uber.com>
@ghost ghost assigned everett980 Dec 19, 2018
@ghost ghost added the review label Dec 19, 2018
Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…set-viewing-layer-zoom

Signed-off-by: Everett Ross <reverett@uber.com>
@everett980 everett980 merged commit 0a0cf66 into jaegertracing:master Jan 3, 2019
@ghost ghost removed the review label Jan 3, 2019
everett980 added a commit to everett980/jaeger-ui that referenced this pull request Jan 16, 2019
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
@tiffon tiffon mentioned this pull request Mar 24, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
…racing#290)

* Add button to reset viewing layer zoom (jaegertracing#215)

Signed-off-by: Everett Ross <reverett@uber.com>

* Adhere to className pattern, sort imports, remove event handling

Signed-off-by: Everett Ross <reverett@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants