Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Collapse One" button throws an error when trace is fully collapsed #229

Closed
yuribit opened this issue Jul 24, 2018 · 1 comment
Closed

"Collapse One" button throws an error when trace is fully collapsed #229

yuribit opened this issue Jul 24, 2018 · 1 comment
Labels
bug

Comments

@yuribit
Copy link
Contributor

yuribit commented Jul 24, 2018 

0
- 1
--- 2
- 3
--- 4
- 5

When you click on the "Collapse One" button for 3 times using the above trace as input, the webapp throws the following error:
Uncaught TypeError: Cannot read property 'spanID' of undefined at collapseOne (duck.js:174)
yuribit pushed a commit to yuribit/jaeger-ui that referenced this issue Jul 24, 2018
Fix CollapseOne action. Fix jaegertracing#229
a841080
yuribit pushed a commit to yuribit/jaeger-ui that referenced this issue Jul 24, 2018
Fix CollapseOne action. Fix jaegertracing#229
9c92c36 
Signed-off-by: Yuri Roncella <yuri.roncella@gmail.com>
@yuribit yuribit mentioned this issue Jul 24, 2018
Merged
yuribit pushed a commit to yuribit/jaeger-ui that referenced this issue Jul 24, 2018
Fix CollapseOne action. Fix jaegertracing#229
e3a7e91 
Signed-off-by: Yuri Roncella <yroncella@apple.com>
@yurishkuro yurishkuro added the bug label Jul 24, 2018
@tiffon
Copy link
Member

tiffon commented Jul 24, 2018

Thank you for filing!

tiffon pushed a commit that referenced this issue Jul 25, 2018
@yuribit @tiffon
Fix CollapseOne action. Fix #229 (#230)
fc2e638 
Signed-off-by: Yuri Roncella <yroncella@apple.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@yuribit @tiffon
Fix CollapseOne action. Fix jaegertracing#229 (jaegertracing#230)
e8fd1e4 
Signed-off-by: Yuri Roncella <yroncella@apple.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuribit @tiffon @yurishkuro