Fix CollapseOne action #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Roncella <yroncella@apple.com>
yuribit
force-pushed
the
fix-collapse-one
branch
from
9c92c36
to
e3a7e91
Compare
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 90.03% 90.03% +<.01%
==========================================
Files 107 107
Lines 2368 2369 +1
Branches 481 482 +1
==========================================
+ Hits 2132 2133 +1
Misses 198 198
Partials 38 38
Continue to review full report at Codecov.
|
|
cc @davit-y |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Signed-off-by: Yuri Roncella <yroncella@apple.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #229
Short description of the changes
nearestCollapsedAncestorshould always have children otherwise in some particular cases (see test) it will be incorrectly added tochildrenHiddenIDs.