Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace - RangeError: Invalid array length #259

Closed
tiffon opened this issue Oct 1, 2018 · 0 comments
Closed

Trace - RangeError: Invalid array length #259

tiffon opened this issue Oct 1, 2018 · 0 comments
Assignees
Labels

Comments

@tiffon
Copy link
Member

tiffon commented Oct 1, 2018

Requirement - what kind of business use case are you trying to solve?

Trace detail page functioning without error.

Problem - what in Jaeger blocks you from solving the requirement?

This issue was observed on a trace with ~1000 spans.

If the user scrolls down halfway through the trace and then collapses all parents (assuming this results in all or most of the trace being collapsed), there is a JavaScript error:

Uncaught RangeError: Invalid array length
    at ListView.render (index.js:425)
    at finishClassComponent (react-dom.development.js:8389)
    at updateClassComponent (react-dom.development.js:8357)
    at beginWork (react-dom.development.js:8982)
    at performUnitOfWork (react-dom.development.js:11814)
    at workLoop (react-dom.development.js:11843)
    at renderRoot (react-dom.development.js:11874)
    at performWorkOnRoot (react-dom.development.js:12449)
    at performWork (react-dom.development.js:12370)
    at performSyncWork (react-dom.development.js:12347)
    at interactiveUpdates (react-dom.development.js:12597)
    at interactiveUpdates (react-dom.development.js:1958)
    at dispatchInteractiveEvent (react-dom.development.js:4259)

With the following output by React's default error boundary behavior:

The above error occurred in the <ListView> component:
    in ListView (at VirtualizedTraceView.js:379)
    in div (at VirtualizedTraceView.js:378)
    in VirtualizedTraceViewImpl (created by Connect(VirtualizedTraceViewImpl))
    in Connect(VirtualizedTraceViewImpl) (at index.js:108)
    in div (at index.js:94)
    in TraceTimelineViewerImpl (created by Connect(TraceTimelineViewerImpl))
    in Connect(TraceTimelineViewerImpl) (at index.js:377)
    in section (at index.js:376)
    in div (at index.js:341)
    in TracePageImpl (created by Connect(TracePageImpl))
    in Connect(TracePageImpl) (created by Route)
    in Route (at index.js:55)
    in Switch (at index.js:52)
    in div (created by Basic)
    in Basic (created by Adapter)
    in Adapter (at Page.js:62)
    in div (created by BasicLayout)
    in BasicLayout (created by Adapter)
    in Adapter (at Page.js:58)
    in div (at Page.js:56)
    in PageImpl (created by Connect(PageImpl))
    in Connect(PageImpl) (created by Route)
    in Route (created by withRouter(Connect(PageImpl)))
    in withRouter(Connect(PageImpl)) (at index.js:51)
    in Router (created by ConnectedRouter)
    in ConnectedRouter (at index.js:50)
    in Provider (at index.js:49)
    in JaegerUIApp (at index.js:43)

Proposal - what do you suggest to solve the problem or improve the existing situation?

Fix the bug.

@tiffon tiffon added the bug label Oct 1, 2018
@tiffon tiffon self-assigned this Oct 2, 2018
tiffon added a commit that referenced this issue Oct 8, 2018
Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost added the review label Oct 8, 2018
tiffon added a commit that referenced this issue Oct 11, 2018
Investigated the license issues, manually, and they're fine.

* Upgrade to ant-design 3.8.0

Signed-off-by: Joe Farro <joef@uber.com>

* Fix issues with expand / collapse - #259 and #260

Signed-off-by: Joe Farro <joef@uber.com>

* Use yarn registry

Signed-off-by: Joe Farro <joef@uber.com>
@ghost ghost removed the review label Oct 11, 2018
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
Investigated the license issues, manually, and they're fine.

* Upgrade to ant-design 3.8.0

Signed-off-by: Joe Farro <joef@uber.com>

* Fix issues with expand / collapse - jaegertracing#259 and jaegertracing#260

Signed-off-by: Joe Farro <joef@uber.com>

* Use yarn registry

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant