Fix collapse all issues #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
ghost
assigned Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 77.05% 77.12% +0.07%
==========================================
Files 135 135
Lines 2950 2955 +5
Branches 613 613
==========================================
+ Hits 2273 2279 +6
+ Misses 534 533 -1
Partials 143 143
Continue to review full report at Codecov.
|
saminzadeh
approved these changes
Oct 11, 2018
|
Hi, I was trying out the latest code, and I found a weird issue where the dragger line extends past its bounds, essentially covering the page's full height: |
|
Thanks for reporting - booked as #269 |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Investigated the license issues, manually, and they're fine. * Upgrade to ant-design 3.8.0 Signed-off-by: Joe Farro <joef@uber.com> * Fix issues with expand / collapse - jaegertracing#259 and jaegertracing#260 Signed-off-by: Joe Farro <joef@uber.com> * Use yarn registry Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves issues with the expand and collapse.
Fix #259.
Fix #260.
Short description of the changes
Avert JS errors and scrolling problems when using collapse all.