Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jeager UI broken when accessing via IPv6 address #491

Closed
MaheshGPai opened this issue Dec 2, 2019 · 2 comments
Closed

Jeager UI broken when accessing via IPv6 address #491

MaheshGPai opened this issue Dec 2, 2019 · 2 comments
Labels
help wanted

Comments

@MaheshGPai
Copy link

MaheshGPai commented Dec 2, 2019 •
edited
Loading

Requirement - what kind of business use case are you trying to solve?

Deploying jaeger in a pure IPv6 setup

Problem - what in Jaeger blocks you from solving the requirement?

Logical issue in Jaeger UI module. The logic to determine pathPrefix does not consider that the origin may contain RegEx characters like "[" & "]"

image

Proposal - what do you suggest to solve the problem or improve the existing situation?

Correct the logic to determine pathPrefix

Any open questions to address
@MaheshGPai MaheshGPai reopened this Dec 2, 2019
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 3, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
0764bc6 
…#491)
@MaheshGPai
Copy link
Author

PR #494

MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 3, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
9e3388e 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
@MaheshGPai MaheshGPai mentioned this issue Dec 3, 2019
Merged
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 5, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
b69aba4 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 5, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
7342c87 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 5, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
1f70dd0 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 5, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
cb3f39e 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 6, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
f0b5dda 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
MaheshGPai pushed a commit to MaheshGPai/jaeger-ui that referenced this issue Dec 10, 2019
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
e9a9d2d 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
everett980 added a commit that referenced this issue Dec 10, 2019
@everett980
Merge pull request #494 from MaheshGPai/master
36ab156 
Fixes Jeager UI broken when accessing via IPv6 address (#491)
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing…
9afe0ae 
…#491)

Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@everett980
Merge pull request jaegertracing#494 from MaheshGPai/master
01dbc04 
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing#491)
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
@jkowall
Copy link
Contributor

jkowall commented Oct 27, 2021

Looks like this was fixed now. Thanks!

@jkowall jkowall closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jkowall @yurishkuro @MaheshGPai