Jaeger UI broken when accessing via IPv6 address (#491) #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you add unit tests? |
MaheshGPai
force-pushed
the
master
branch
4 times, most recently
from
1f70dd0
to
cb3f39e
Compare
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 92.75% 92.76% +<.01%
==========================================
Files 193 193
Lines 4652 4655 +3
Branches 1119 1121 +2
==========================================
+ Hits 4315 4318 +3
Misses 297 297
Partials 40 40
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Dec 5, 2019
|
@everett980 please review |
everett980
requested changes
Dec 9, 2019
There was a problem hiding this comment.
Thanks for the PR @MaheshGPai! Sorry it took me so long to get to this PR, I didn't see that the tests were added.
I've requested some small stylistic changes, but otherwise it looks good.
…#491) Signed-off-by: Mahesh PAI R <mahesh.pai_r@nokia.com>
|
Have incorporated the requested changes. |
everett980
approved these changes
Dec 10, 2019
pavolloffay
changed the title
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
Fixes Jeager UI broken when accessing via IPv6 address (jaegertracing#491) Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Jeager UI broken when accessing via IPv6 address (#491)
Short description of the changes
Corrected the logic to determine pathPrefix by escaping RegEx characters