Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify stored search settings are valid before defaulting to them #88

Closed
tiffon opened this issue Sep 29, 2017 · 0 comments
Closed

Verify stored search settings are valid before defaulting to them #88

tiffon opened this issue Sep 29, 2017 · 0 comments
Assignees
Labels

Comments

@tiffon
Copy link
Member

tiffon commented Sep 29, 2017

I sometimes have an issue where I bring up empty Jaeger UI (e.g. from a fresh all-in-one Docker image), so the Services dropdown is supposed to be empty, but the screen renders with a value from the previous runs on the same URL. I know we store the previously selected service name in local storage, but when we retrieve it we should probably check if the value is actually in the list of currently available services.

@tiffon tiffon added the bug label Oct 20, 2017
tiffon added a commit that referenced this issue Oct 27, 2017
Fix #88.

Preload operations for stored service search value.

On the search page, show a loading indicator if the services are not yet loaded.
Then, only use the values stored in localStorage if they are consistent with
what has been loaded.

Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
Fix jaegertracing#88.

Preload operations for stored service search value.

On the search page, show a loading indicator if the services are not yet loaded.
Then, only use the values stored in localStorage if they are consistent with
what has been loaded.

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant