Verify stored search settings #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services default to null when no traces have been encountered. Instead, use an empty array. Signed-off-by: Joe Farro <joef@uber.com>
Fix #88. Preload operations for stored service search value. On the search page, show a loading indicator if the services are not yet loaded. Then, only use the values stored in localStorage if they are consistent with what has been loaded. Signed-off-by: Joe Farro <joef@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…ed-search-settings Verify stored search settings Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88.
Preload operations for stored service search value.
On the search page, show a loading indicator if the services are not yet loaded.
Then, only use the values stored in localStorage if they are consistent with
what has been loaded.
Signed-off-by: Joe Farro joef@uber.com