Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: how to run/test the UI #952

Closed
esnible opened this issue May 15, 2022 · 3 comments
Closed

Docs: how to run/test the UI #952

esnible opened this issue May 15, 2022 · 3 comments
Labels

Comments

@esnible
Copy link
Contributor

esnible commented May 15, 2022

Attempting to follow the directions at https://github.com/jaegertracing/jaeger-ui#development by doing yarn start brings up a screen that says Unhandled Rejection (Error): HTTP Error: Error occured while trying to proxy to: localhost:3000/api/services.

I have another Jaeger running at 16686, but the instructions don't explain how to point the yarn start version at :3000.

The way I have been testing UI changes is:

  • Make the changes in the jaegar/jaeger-ui submodule
  • yarn build (from the jaeger-ui submodule directory)
  • make run-all-in-one (from the jaeger directory)
  • hard-reload the browser

I am happy to make a PR to change the doc to my method. If there is a better way to make the yarn start UI talk to :16686 that would be better than doing a build for each change.

@esnible esnible added the bug label May 15, 2022
@yurishkuro
Copy link
Member

I am not sure what specific issue you're running into. My understanding is that yarn start runs a web server on port 3000 that serves UI assets (with hot reloading support), but the API requests are being proxied to the standard port :16686 where Jaeger is expected to be running.

I just tried it, run $ go run ./cmd/all-in-one in jaeger/ and then yarn start in jaeger-ui/

yurishkuro added a commit that referenced this issue May 15, 2022
@esnible
Copy link
Contributor Author

esnible commented May 15, 2022

Ah, thanks for checking. I was able to duplicate your process. You are correct; there is no problem with the UI.

I run Jaeger using

ADMIN_HTTP_HOST_PORT=localhost:14269 HTTP_SERVER_HOST_PORT=localhost:5778 \
COLLECTOR_GRPC_SERVER_HOST_PORT=localhost:14250 COLLECTOR_HTTP_SERVER_HOST_PORT=localhost:14268 \
QUERY_HTTP_SERVER_HOST_PORT=localhost:16686 QUERY_GRPC_SERVER_HOST_PORT=localhost:16685 \
PROCESSOR_JAEGER_BINARY_SERVER_HOST_PORT=localhost:6832 \
make run-all-in-one

I do that because, on a Mac, Jaeger's defaults lead to many "Do you want the application 'all-in-one' to accept incoming network connections?" dialogs popping up. Having the server listen on localhost instead of 0.0.0.0 eliminates those dialogs -- but is not compatible with the proxying done by yarn start.

Using QUERY_HTTP_SERVER_HOST_PORT=0.0.0.0:16686 or merely using the default allows yarn start to work correctly.

I found this surprising. I tried to investigate, and found packages/jaeger-ui/src/setupProxy.js. I'm not a yarn guy. I couldn't figure out why listening on 127.0.0.1 is OK with curl localhost:16686 but not with yarn's proxying.

@esnible
Copy link
Contributor Author

esnible commented May 18, 2022

Closing because I have a report that this work correctly on Linux. It isn't clear what the Mac problem is, or if every Mac user experiences it. The work-around of not overriding the QUERY_HTTP_SERVER_HOST_PORT flag when testing is sufficient.

@esnible esnible closed this as completed May 18, 2022
VladislavBryukhanov pushed a commit to VladislavBryukhanov/jaeger-ui that referenced this issue May 26, 2022
For jaegertracing#952

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>
yurishkuro added a commit that referenced this issue May 30, 2022
* Added new SPM tracing events tracking

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Added tests for new SPM events

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* reworked tracking categories & actions names

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* fixed license block dates; moved debounce from tracking module to component

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Fix monitor tab crashing (#946)

Signed-off-by: nofar9792 <nofar.cohen@logz.io>
Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Add repository to package.json (#949)

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Preparing release v1.23.0 (#947)

* Preparing release v1.23.0

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

* Fix

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Bump github/codeql-action from 1 to 2 (#938)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v1...v2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Clarify development setup

For #952

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Use red on scatterplot for traces if any spans have an error=true tag (#951)

* Use red on scatterplot for traces if any spans have an error=true tag

Signed-off-by: Ed Snible <snible@us.ibm.com>

* Used 'yarn prettier' to appease 'yarn lint'

Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

* Updated sorting events tracking

Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>

Co-authored-by: nofar9792 <nofar.cohen@logz.io>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ed Snible <esnible@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants