Use red on scatterplot for traces if any spans have an error=true tag #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
esnible
force-pushed
the
scatterplot-red-errors
branch
from
6a2efad
to
1b2b36f
Compare
rubenvp8510
reviewed
May 13, 2022
packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.js
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #951 +/- ##
==========================================
- Coverage 95.31% 95.28% -0.04%
==========================================
Files 240 240
Lines 7521 7524 +3
Branches 1832 1887 +55
==========================================
Hits 7169 7169
- Misses 346 348 +2
- Partials 6 7 +1
Continue to review full report at Codecov.
|
rubenvp8510
approved these changes
May 16, 2022
VladislavBryukhanov
pushed a commit
to VladislavBryukhanov/jaeger-ui
that referenced
this pull request
May 26, 2022
…jaegertracing#951) * Use red on scatterplot for traces if any spans have an error=true tag Signed-off-by: Ed Snible <snible@us.ibm.com> * Used 'yarn prettier' to appease 'yarn lint' Signed-off-by: Ed Snible <snible@us.ibm.com> Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com>
yurishkuro
added a commit
that referenced
this pull request
May 30, 2022
* Added new SPM tracing events tracking Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Added tests for new SPM events Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * reworked tracking categories & actions names Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * fixed license block dates; moved debounce from tracking module to component Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Fix monitor tab crashing (#946) Signed-off-by: nofar9792 <nofar.cohen@logz.io> Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Add repository to package.json (#949) Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Preparing release v1.23.0 (#947) * Preparing release v1.23.0 Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Bump github/codeql-action from 1 to 2 (#938) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v1...v2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Clarify development setup For #952 Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Use red on scatterplot for traces if any spans have an error=true tag (#951) * Use red on scatterplot for traces if any spans have an error=true tag Signed-off-by: Ed Snible <snible@us.ibm.com> * Used 'yarn prettier' to appease 'yarn lint' Signed-off-by: Ed Snible <snible@us.ibm.com> Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> * Updated sorting events tracking Signed-off-by: VladislavBryukhanov <gfedcba625@gmail.com> Co-authored-by: nofar9792 <nofar.cohen@logz.io> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Pavol Loffay <p.loffay@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ed Snible <esnible@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Snible snible@us.ibm.com
Show error traces in red on the scatterplot.
To test this it can be handy to have a source of good-looking traces with errors. I used synthentic data generated by
docker run -it --env JAEGER_COLLECTOR_URL=http://docker.for.mac.localhost:14268 omnition/synthetic-load-generator.Note that this is my first Jaeger-UI PR. When I tried to commit I got a warnings. Resolving them needed some help: I didn't know that I needed to run
yarn prettierto clean my code, noryarn lintto lint it. Is this in the docs? I couldn't find it.