Embed UI config #107
Merged
Embed UI config #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Merge embedded config with default config - Use gaTrackingID from embedded config for Google Analytics tracking Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Joe Farro <joef@uber.com>
yurishkuro
approved these changes
Oct 27, 2017
|
Needed for jaegertracing/jaeger#489 |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Query service embeds config in index.html - Merge embedded config with default config - Use gaTrackingID from embedded config for Google Analytics tracking Signed-off-by: Joe Farro <joef@uber.com> * Add changelog entry for PR 107 Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #85.
Instead of using
/api/configto retrieve the UI config from the query service, the query service embeds it into index.html. The query service replacesDEFAULT_CONFIGwith the actual config:This resolves #85 because it allows the UI to use any GA tracking ID without needed to be rebuilt (e.g. the admin can use the all-in-one docker image and still enable Google Analytics).