Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apache license header to CSS files #108

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Add Apache license header to CSS files #108

merged 1 commit into from
Oct 27, 2017

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Oct 27, 2017

  • Change license header in CSS files to use Apache v2
  • Update license check to also check CSS files
  • Removed uber-license package

Signed-off-by: Joe Farro joef@uber.com

@tiffon
Add Apache license header to CSS files
8f16ebb 
- Update license check to also check CSS files
- Removed uber-license package

Signed-off-by: Joe Farro <joef@uber.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 69.979% when pulling 8f16ebb on css-files-apache-license-header into 79d262d on master.

yurishkuro
yurishkuro approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Have you verified that your change to the check script will find files without copyright?

@tiffon
Copy link
Member Author

tiffon commented Oct 27, 2017

good catch. Have you verified that your change to the check script will find files without copyright?

@yurishkuro I took the license header out of a CSS file and verified it caught it.

@tiffon tiffon merged commit 4e02e45 into master Oct 27, 2017
@yurishkuro yurishkuro deleted the css-files-apache-license-header branch January 29, 2020 15:11
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tiffon
Merge pull request jaegertracing#108 from jaegertracing/css-files-apa…
130526e 
…che-license-header

Add Apache license header to CSS files
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiffon @coveralls @yurishkuro