Upgrade to React 18 #1173
Upgrade to React 18 #1173
Conversation
Sergio-Mira
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov ReportBase: 95.30% // Head: 95.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 95.30% 95.41% +0.10%
==========================================
Files 243 243
Lines 7561 7562 +1
Branches 1895 1895
==========================================
+ Hits 7206 7215 +9
+ Misses 348 340 -8
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| "react-circular-progressbar": "^2.0.3", | ||
| "react-dimensions": "^1.3.0", | ||
| "react-dom": "^16.14.0", | ||
| "react": "^18.2.0", |
There was a problem hiding this comment.
Wow, that looks suspiciously easy, were there really no breaking changes?
There was a problem hiding this comment.
The breaking changes of lifecycle etc have been postponed to upcoming versions of React 18 and are still warnings afaik, and that is why its an easier upgrade. As far as I understand and can test the project still can use dependencies which are not yet fully React 18 compatible (like react-vis in this case).
Would love to hear how to move this PR forward and what we can do to test it, what edge cases of libs we think might break.
(I've also submitted changes to migrate from old lifecycle events in react-vis here uber/react-vis#1473)
Signed-off-by: Sergio-Mira <sergio.mira@zendesk.com>
Sergio-Mira
force-pushed
the
sergio-mira/upgrade-to-react-18
branch
from
f766abd
to
5b1c153
Compare
| @@ -20,7 +20,7 @@ rafPolyfill(); | |||
|
|
|||
| /* eslint-disable import/no-extraneous-dependencies */ | |||
| const Enzyme = require('enzyme'); | |||
| const EnzymeAdapter = require('enzyme-adapter-react-16'); | |||
| const EnzymeAdapter = require('@wojtekmaj/enzyme-adapter-react-17'); | |||
There was a problem hiding this comment.
I can see this is another future PITA to be solved -- https://testing-library.com/docs/react-testing-library/migrate-from-enzyme/
|
Any plans to merge? |
|
@metasal1 merge what? This PR was merged in Feb |
Upgrade to React 18.
Which problem is this PR solving?
Short description of the changes