Bump Plexus React typings to React 18 #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per jaegertracing#998; also update the package's `peerDependencies` accordingly. I am not entirely sure why Dependabot was trying to update these typings separately because bumping them together appears to yield a successful build. Signed-off-by: Máté Szabó <mszabo@fandom.com>
mszabo-wikia
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
Codecov ReportBase: 95.37% // Head: 95.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 95.37% 95.29% -0.08%
==========================================
Files 243 243
Lines 7571 7571
Branches 1898 1898
==========================================
- Hits 7221 7215 -6
- Misses 343 349 +6
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
🎉 |
Binrix
pushed a commit
to Binrix/jaeger-ui
that referenced
this pull request
Apr 18, 2023
## Which problem is this PR solving? Contributes towards jaegertracing#998 ## Short description of the changes Bump Plexus React typings to React 18 and also update the package's `peerDependencies` accordingly. I am not entirely sure why Dependabot was trying to update these typings separately because bumping them together appears to yield a successful build. Signed-off-by: Máté Szabó <mszabo@fandom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Contributes towards #998
Short description of the changes
Bump Plexus React typings to React 18 and also update the package's
peerDependenciesaccordingly. I am not entirely sure why Dependabot was trying to update these typings separately because bumping them together appears to yield a successful build.