Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Redux selectors #1284

Merged
merged 1 commit into from
Mar 18, 2023

Commits on Mar 18, 2023

  1. Remove unused Redux selectors

    Some of the inconsistency of coverage results is due to randomly
    generated test data in trace.test.js. While investigating, however, I
    noticed that most of the Redux selectors in this directory were only
    referenced by each other and by tests - it seems they were used at some
    point (they're in use in the initial commit) but were progressively
    removed by refactorings. Since selectors only serve to encapsulate and
    reuse logic to lookup data from the Redux store[1], they are not useful
    when not imported. As such, take this opportunity to remove the dead
    code.
    
    ---
    [1] https://redux.js.org/usage/deriving-data-selectors
    
    Signed-off-by: Máté Szabó <mszabo@fandom.com>
    mszabo-wikia committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    5d2cd36 View commit details
    Browse the repository at this point in the history