Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode service names in API calls #140

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Encode service names in API calls #140

merged 1 commit into from
Dec 19, 2017

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Dec 18, 2017

Fix #138.

@tiffon
Encode service names in API calls
5ea033b 
Signed-off-by: Joe Farro <joef@uber.com>
black-adder
black-adder approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any other places in the API that need this treatment?

@codecov
Copy link

codecov bot commented Dec 18, 2017 •
edited
Loading

Codecov Report

Merging #140 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   92.16%   92.38%   +0.22%     
==========================================
  Files          81       81              
  Lines        1799     1905     +106     
  Branches      348      379      +31     
==========================================
+ Hits         1658     1760     +102     
- Misses        129      132       +3     
- Partials       12       13       +1
Impacted Files Coverage Δ
src/api/jaeger.js 88.23% <100%> (ø) ⬆️
src/components/TracePage/TracePageHeader.js 91.66% <0%> (-1.2%) ⬇️
...rc/components/SearchTracePage/TraceSearchResult.js 100% <0%> (ø) ⬆️
src/model/search.js 100% <0%> (ø) ⬆️
src/components/TracePage/index.js 99.25% <0%> (+0.39%) ⬆️
src/components/App/TraceIDSearchInput.js 15.38% <0%> (+1.09%) ⬆️
src/reducers/trace.js 82.35% <0%> (+3.78%) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 92.59% <0%> (+5.55%) ⬆️
...ponents/SearchTracePage/TraceResultsScatterPlot.js 44.44% <0%> (+8.08%) ⬆️
src/model/transform-trace-data.js 88.67% <0%> (+9.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbc3025...5ea033b. Read the comment docs.

@tiffon
Copy link
Member Author

tiffon commented Dec 19, 2017

@black-adder I don't think so. The other endpoint names are static.

@tiffon tiffon merged commit 9f6a804 into master Dec 19, 2017
@tiffon tiffon mentioned this pull request Jan 3, 2018
Closed
This was referenced Mar 12, 2018
Closed
Closed
@yurishkuro yurishkuro deleted the issue-138-encode-svc-names branch January 29, 2020 15:11
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
@tiffon
Merge pull request jaegertracing#140 from jaegertracing/issue-138-enc…
e5b45c8 
…ode-svc-names

Encode service names in API calls
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@vprithvi vprithvi Awaiting requested review from vprithvi

@saminzadeh saminzadeh Awaiting requested review from saminzadeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiffon @black-adder @yurishkuro