Fix flaky test causing spurious drops in code coverage

[GLVSKiriti]

Which problem is this PR solving?

• Resolves [bug] Flaky test causing spurious drops in code coverage #1489

Short description of the changes

• To remove the non determinism in the code

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (5489990) 95.99% compared to head (22c06df) 96.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   95.99%   96.01%   +0.02%     
==========================================
  Files         242      242              
  Lines        7559     7559              
  Branches     1984     1984              
==========================================
+ Hits         7256     7258       +2     
+ Misses        303      301       -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

could you please explain why this change works?

[GLVSKiriti]

could you please explain why this change works?

jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.test.js

Lines 45 to 48 in b4a49a7

	getViewedBounds: jest
	.fn()
	.mockReturnValueOnce({ start: 0.5, end: 0.6 })
	.mockReturnValue({ start: 0, end: 1 }),

Here I am trying to execute if code block at least once . As previously getViewBounds function always returns {start:0,end:1} so always else block is executed in test

jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.tsx

Lines 117 to 122 in b4a49a7

	if (viewStart > 1 - viewEnd) {
	longLabel = `${labelDetail} | ${label}`;
	hintSide = 'left';
	} else {
	longLabel = `${label} | ${labelDetail}`;
	hintSide = 'right';

[yurishkuro]

two different mock returns are good if the function is guaranteed to be called multiple times in the test. Is it?

[GLVSKiriti]

two different mock returns are good if the function is guaranteed to be called multiple times in the test. Is it?

Yes we are calling multiple times in the test file

jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.test.js

Lines 111 to 133 in b4a49a7

	const spanRow = shallow(<SpanBarRow {...props} span={span} />);
	const refButton = spanRow.find(ReferencesButton);
	expect(refButton.length).toEqual(1);
	expect(refButton.at(0).props().tooltipText).toEqual('Contains multiple references');
	});
	it('render referenced to by single span', () => {
	const span = Object.assign(
	{
	subsidiarilyReferencedBy: [
	{
	refType: 'CHILD_OF',
	traceID: 'trace1',
	spanID: 'span0',
	span: {
	spanID: 'span0',
	},
	},
	],
	},
	props.span
	);
	const spanRow = shallow(<SpanBarRow {...props} span={span} />);

Indirectly for every shallow render getViewBounds function is called

[yurishkuro]

thanks!