Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Remove @types/moment, @types/history and @types/classnames #1637

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

anshgoyalevil
Copy link
Contributor

Which problem is this PR solving?

  • This PR remove the @types/moment, @types/history and @types/classnames packages since these are stub types definitions. Their respective packages provide their own type definitions, so we do not need this installed.

Description of the changes

  • This PR remove the @types/moment, @types/history and @types/classnames packages since these are stub types definitions. Their respective packages provide their own type definitions, so we do not need this installed.

How was this change tested?

  • using yarn start and yarn lint

Checklist

Signed-off-by: Ansh Goyal <anshgoyal1704@gmail.com>
@anshgoyalevil
Copy link
Contributor Author

//cc @yurishkuro 🚀

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ffe3f7f) 96.01% compared to head (ed14ce0) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1637   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         242      242           
  Lines        7559     7559           
  Branches     1984     1984           
=======================================
  Hits         7258     7258           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yurishkuro yurishkuro merged commit 425fe08 into jaegertracing:main Aug 4, 2023
8 checks passed
@anshgoyalevil anshgoyalevil deleted the rmd branch August 5, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants