Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tooltip position of copy value and JSON Buttton #1650

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Aug 8, 2023

fix #1649

Screenshot 2023-08-09 045507

Checklist

yurishkuro
yurishkuro previously approved these changes Aug 9, 2023
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro changed the title fix: Fix the tooltip position of copy value and JSON Buttton Fix the tooltip position of copy value and JSON Buttton Aug 9, 2023
@yurishkuro
Copy link
Member

You may need to regenerate the snapshots yarn test -u

@anikdhabal
Copy link
Contributor Author

You may need to regenerate the snapshots yarn test -u

okk

Copy link
Contributor

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!!

@yurishkuro
Copy link
Member

CI is still failing

@anshgoyalevil
Copy link
Contributor

anshgoyalevil commented Aug 11, 2023

@anikdhabal You would need to run yarn test -u inside the packages/jaeger-ui` directory. The changes made (Snapshots are updated automatically bts) thereafter would need to be committed to this PR.

@anikdhabal
Copy link
Contributor Author

@anikdhabal You would need to run yarn test -u inside the packages/jaeger-ui` directory. The changes made (Snapshots are updated automatically bts) thereafter would need to be committed to this PR.

Yeah, thanks man.

Anik Dhabal Babu and others added 2 commits August 11, 2023 18:45
Signed-off-by: Anik Dhabal Babu <adhabal2002@gamil.com>
Signed-off-by: Anik Dhabal Babu <adhabal2002@gmail.com>
Signed-off-by: Anik Dhabal Babu <adhabal2002@gmail.com>
@anikdhabal
Copy link
Contributor Author

You may need to regenerate the snapshots yarn test -u

Done

@yurishkuro yurishkuro enabled auto-merge (squash) August 11, 2023 19:09
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2444799) 96.01% compared to head (4cea8af) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1650   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         241      241           
  Lines        7558     7558           
  Branches     1984     1984           
=======================================
  Hits         7257     7257           
  Misses        301      301           
Files Changed Coverage Δ
...kages/jaeger-ui/src/components/common/CopyIcon.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 848bfa0 into jaegertracing:main Aug 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Change the tooltip position of Copy value & json
4 participants