Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Change the tooltip position of Copy value & json #1649

Closed
anikdhabal opened this issue Aug 8, 2023 · 3 comments · Fixed by #1650
Closed

[Bug]: Change the tooltip position of Copy value & json #1649

anikdhabal opened this issue Aug 8, 2023 · 3 comments · Fixed by #1650

Comments

@anikdhabal
Copy link
Contributor

anikdhabal commented Aug 8, 2023

What happened?

After hovering over the 'Copy JSON' button, I am unable to access the 'Copy Value' button. The tooltip of the 'Copy JSON' button is blocking the 'Copy Value' button.

Steps to reproduce

1.Hover over the copy json button

Expected behavior

It would be better if the tooltip were positioned at the top or if the value of mouseLeaveDelay is 0.

Relevant log output

No response

Screenshot

Screenshot 2023-08-09 023328

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@anikdhabal anikdhabal added the bug label Aug 8, 2023
@yurishkuro
Copy link
Member

yeah, I also found it annoying. You can still just move off the right button and the left one becomes visible, but if it's an easy fix then we should fix it.

@anikdhabal
Copy link
Contributor Author

yeah, I also found it annoying. You can still just move off the right button and the left one becomes visible, but if it's an easy fix then we should fix it.

Yes, I will create a Pr then.

@sivasathyaseeelan
Copy link

sivasathyaseeelan commented Aug 9, 2023

Hi @yurishkuro, I think in

<Tooltip
        arrowPointAtCenter
        mouseLeaveDelay={0.1}
        onVisibleChange={this.handleTooltipVisibilityChange}
        placement={this.props.placement}
        title={this.state.hasCopied ? 'Copied' : this.props.tooltipTitle}
      >

only mouseLeaveDelay={0} works.

with mouseLeaveDelay={0.1}

with.mouseLeaveDelay.0.1.mp4

with mouseLeaveDelay={0}

with.mouseLeaveDelay.0.mp4

@yurishkuro can I go and create a new PR?

yurishkuro added a commit that referenced this issue Aug 11, 2023
Resolves #1649 

![Screenshot 2023-08-09
045507](https://github.com/jaegertracing/jaeger-ui/assets/81948346/774c75fd-bacf-42f0-9db4-87fce92a1bc3)

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality

---------

Signed-off-by: Anik Dhabal Babu <adhabal2002@gamil.com>
Signed-off-by: Anik Dhabal Babu <adhabal2002@gmail.com>
Co-authored-by: Anik Dhabal Babu <adhabal2002@gamil.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants