Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1697 - Bug fix of popover not closing #1705

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Resolves #1697 - Bug fix of popover not closing #1705

merged 1 commit into from
Aug 21, 2023

Conversation

jriyyya
Copy link
Contributor

@jriyyya jriyyya commented Aug 21, 2023

Signed-off-by: Riya Jain riya1jain567@gmail.com

Which problem is this PR solving?

Resolves #1697

Description of the changes

Added a z-index in TraceDiffGraph so that now when the user click outside the popup it will get closed.

Checklist

Signed-off-by: Riya Jain <riya1jain567@gmail.com>
@jriyyya
Copy link
Contributor Author

jriyyya commented Aug 21, 2023

@yurishkuro You can merge this now.

@yurishkuro yurishkuro enabled auto-merge (squash) August 21, 2023 06:34
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4f7c754) 96.01% compared to head (16208ab) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1705   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         241      241           
  Lines        7562     7562           
  Branches     1987     1987           
=======================================
  Hits         7261     7261           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 3b088fc into jaegertracing:main Aug 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Popover component not closing after clicking outside the component on Compare page
2 participants