Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Extend try/catch for critical path #1778

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[fix] Extend try/catch for critical path #1778

merged 1 commit into from
Sep 12, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • CP logic was still failing randomly in tests

Description of the changes

  • Move try/catch to a larger portion

How was this change tested?

  • CI

@yurishkuro
[fix] Extend try/catch for critical path
3cb7ae6 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage is 95.34% of modified lines.

Files Changed Coverage
packages/jaeger-ui/src/selectors/trace.tsx 81.81%
...ui/src/components/TracePage/CriticalPath/index.tsx 100.00%
...kages/jaeger-ui/src/model/transform-trace-data.tsx 100.00%
packages/jaeger-ui/src/utils/TreeNode.tsx 100.00%

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 777e670 into jaegertracing:main Sep 12, 2023
7 of 9 checks passed
@yurishkuro yurishkuro deleted the cleanup-cp2 branch September 12, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro