Prepare release v1.34.0 #1844
Closed
Prepare release v1.34.0 #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
albertteoh
commented
Oct 4, 2023
| @@ -1,20 +1,17 @@ | |||
| # Cutting a Jaeger UI release | |||
|
|
|||
| 1. Determine the version for the release. | |||
There was a problem hiding this comment.
I felt the instructions could be improved to be a bit more succinct.
There was a problem hiding this comment.
I don't know, don't think original text hurts, especially if a new person is doing it for the first time
There was a problem hiding this comment.
but I see you copied it below, so good
| - Tip: Run `node scripts/get-changelog.js` script that prints a dozen most recent commits in the chagelog format. | ||
| 2. CHANGELOG.md | ||
| - Change the version of the current release from "Next (unreleased)" to "vX.Y.Z (Month D, YYYY)" where "vX.Y.Z" is the [semver](https://semver.org) for this release. | ||
| - Run `make changelog` to list all changes since the last release. |
There was a problem hiding this comment.
Given the jaeger maintainers are (currently) releasing both jaeger-ui and jaeger, I thought to make the experience more consistent between the two repos, hence the introduction of a Makefile and the same python scripts used to generate the changelog. Please let me know if you disagree and I can revert.
If we agree to this change, I could also remove the existing get-changelog.js and get-tracking-version.js scripts if they're not used for any other purpose other than for releases.
scripts/release-notes.py
Outdated
| parser.add_argument('--num-commits', type=int, | ||
| help='Print this number of commits from git log. ' + | ||
| '(default: number of commits before the previous tag)') | ||
| parser.add_argument('--point-markdown-char', type=str, default='*', |
There was a problem hiding this comment.
This script is essentially a copy-paste of https://github.com/jaegertracing/jaeger/blob/main/scripts/release-notes.py with some minor enhancements such as making the point markdown char configurable for consistency with the existing convention, as well as auto-capitalizing sentences in each point, which have been used to generate the above change log.
If we think these improvements are worthwhile keeping, I can sync it up with the jaeger repo.
There was a problem hiding this comment.
I would actually prefer to have just a single copy of the full script in the main repo, and in this repo have a thin wrapper that will download the other script from github.
There was a problem hiding this comment.
Do you think we should do the same for scripts/draft-release.py as well? We'd need to make some minor differences that would need to be either make configurable or opinionated.
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
## Which problem is this PR solving? - Resolves jaegertracing#1784 ## Description of the changes - All the Ant Design's Select fields are now searchable - Added new util to override default behaviour of searching by value instead of label ## How was this change tested? - The test was done manually - I'll add tests if this approach seems okay ## Screenshot <img width="442" alt="Screenshot 2023-09-19 at 2 05 21 PM" src="https://github.com/jaegertracing/jaeger-ui/assets/28570857/4a728e52-cc7e-4f14-b0ea-64c7b481c16f"> ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Prathamesh Mutkure <pmutkure009@gmail.com>
yurishkuro
reviewed
Oct 4, 2023
There was a problem hiding this comment.
I just merged a bug fix #1805, please include it in the release
yurishkuro
reviewed
Oct 4, 2023
| - Print suggestion on fixing prettier-lint errors ([@yurishkuro](https://github.com/yurishkuro) in [#1783](https://github.com/jaegertracing/jaeger-ui/pull/1783)) | ||
| - Upgrade to node 18 ([@yurishkuro](https://github.com/yurishkuro) in [#1776](https://github.com/jaegertracing/jaeger-ui/pull/1776)) | ||
| - Extend try/catch for critical path ([@yurishkuro](https://github.com/yurishkuro) in [#1778](https://github.com/jaegertracing/jaeger-ui/pull/1778)) | ||
| - Convert utils/treenode.js and selectors/trace.js to typescript ([@yurishkuro](https://github.com/yurishkuro) in [#1777](https://github.com/jaegertracing/jaeger-ui/pull/1777)) |
There was a problem hiding this comment.
Looking at a mishmash of topics here I kinda want to resurrect our attempt at labeling the PRs into categories jaegertracing/jaeger#4799
Bumps the vite group with 1 update: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/v4.4.10/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw HTML omitted -->4.4.10 (2023-10-03)<!-- raw HTML omitted --></h2> <ul> <li>fix: add source map to Web Workers (fix <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14216">#14216</a>) (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14217">#14217</a>) (<a href="https://github.com/vitejs/vite/commit/df6f32f">df6f32f</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14216">#14216</a> <a href="https://redirect.github.com/vitejs/vite/issues/14217">#14217</a></li> <li>fix: handle errors during <code>hasWorkspacePackageJSON</code> function (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14394">#14394</a>) (<a href="https://github.com/vitejs/vite/commit/6f6e5de">6f6e5de</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14394">#14394</a></li> <li>fix: handle sourcemap correctly when multiple line import exists (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14232">#14232</a>) (<a href="https://github.com/vitejs/vite/commit/218861f">218861f</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14232">#14232</a></li> <li>fix: if host is specified check whether it is valid (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14013">#14013</a>) (<a href="https://github.com/vitejs/vite/commit/b1b816a">b1b816a</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14013">#14013</a></li> <li>fix: include <code>vite/types/*</code> in exports field (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14296">#14296</a>) (<a href="https://github.com/vitejs/vite/commit/40e99a1">40e99a1</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14296">#14296</a></li> <li>fix: initWasm options should be optional (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14152">#14152</a>) (<a href="https://github.com/vitejs/vite/commit/119c074">119c074</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14152">#14152</a></li> <li>fix: restore builtins list (<a href="https://github.com/vitejs/vite/commit/f8b9adb">f8b9adb</a>)</li> <li>fix: use string manipulation instead of regex to inject esbuild helpers (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14094">#14094</a>) (<a href="https://github.com/vitejs/vite/commit/128ad8f">128ad8f</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14094">#14094</a></li> <li>fix: ws never connects after restarting server if server.hmr.server is set (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14127">#14127</a>) (<a href="https://github.com/vitejs/vite/commit/441642e">441642e</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14127">#14127</a></li> <li>fix(analysis): warnings for dynamic imports that use static template literals (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14458">#14458</a>) (<a href="https://github.com/vitejs/vite/commit/0c6d289">0c6d289</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14458">#14458</a></li> <li>fix(cli): convert special base (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14283">#14283</a>) (<a href="https://github.com/vitejs/vite/commit/d4bc0fb">d4bc0fb</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14283">#14283</a></li> <li>fix(css): remove pure css chunk sourcemap (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14290">#14290</a>) (<a href="https://github.com/vitejs/vite/commit/cd7e033">cd7e033</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14290">#14290</a></li> <li>fix(css): reset render cache on renderStart (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14326">#14326</a>) (<a href="https://github.com/vitejs/vite/commit/d334b3d">d334b3d</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14326">#14326</a></li> <li>fix(glob): trigger HMR for glob in a package (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14117">#14117</a>) (<a href="https://github.com/vitejs/vite/commit/0f582bf">0f582bf</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14117">#14117</a></li> <li>fix(import-analysis): preserve importedUrls import order (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14465">#14465</a>) (<a href="https://github.com/vitejs/vite/commit/269aa43">269aa43</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14465">#14465</a></li> <li>fix(manifest): preserve pure css chunk assets (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14297">#14297</a>) (<a href="https://github.com/vitejs/vite/commit/3d63ae6">3d63ae6</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14297">#14297</a></li> <li>fix(optimizer): define crawlDeps after scanProcessing and optimizationResult are complete (fix <a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/1428">#1428</a> (<a href="https://github.com/vitejs/vite/commit/fcaf749">fcaf749</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14284">#14284</a> <a href="https://redirect.github.com/vitejs/vite/issues/14285">#14285</a></li> <li>fix(resolve): support submodules of optional peer deps (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14489">#14489</a>) (<a href="https://github.com/vitejs/vite/commit/104971d">104971d</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14489">#14489</a></li> <li>fix(vite): precisely check if files are in dirs (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14241">#14241</a>) (<a href="https://github.com/vitejs/vite/commit/c4758d1">c4758d1</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14241">#14241</a></li> <li>feat: improve deno and bun support (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14379">#14379</a>) (<a href="https://github.com/vitejs/vite/commit/8bc1f9d">8bc1f9d</a>), closes <a href="https://redirect.github.com/vitejs/vite/issues/14379">#14379</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/vite/commit/f3a3e77de170166c53ca4d114a110a40bab97463"><code>f3a3e77</code></a> release: v4.4.10</li> <li><a href="https://github.com/vitejs/vite/commit/f8b9adb73dc838f14a41406def918cfd6c9a841e"><code>f8b9adb</code></a> fix: restore builtins list</li> <li><a href="https://github.com/vitejs/vite/commit/104971d9b4b6b3994bc8362e7ffabd7d2bf3c311"><code>104971d</code></a> fix(resolve): support submodules of optional peer deps (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14489">#14489</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/0c6d289a2a34f3e0cd872013c6b8aa7e97e45eb0"><code>0c6d289</code></a> fix(analysis): warnings for dynamic imports that use static template literals...</li> <li><a href="https://github.com/vitejs/vite/commit/269aa4393e326888a4ce76cd7a2e6b1f4d5c3102"><code>269aa43</code></a> fix(import-analysis): preserve importedUrls import order (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14465">#14465</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/6f6e5de0ad8418328d52f58f4786f78b70cc6d3d"><code>6f6e5de</code></a> fix: handle errors during <code>hasWorkspacePackageJSON</code> function (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14394">#14394</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/8bc1f9d3c79137c31dae5fe50384fea0286bc55b"><code>8bc1f9d</code></a> feat: improve deno and bun support (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14379">#14379</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/3d63ae6774b1a1fb015c2d8fa9bd50c074d81827"><code>3d63ae6</code></a> fix(manifest): preserve pure css chunk assets (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14297">#14297</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/d334b3de8cfc968481189643a7ad9baba0c7c36a"><code>d334b3d</code></a> fix(css): reset render cache on renderStart (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14326">#14326</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/fcaf7491f4fbfafbda066dc372a9d2d5249bbce2"><code>fcaf749</code></a> fix(optimizer): define crawlDeps after scanProcessing and optimizationResult ...</li> <li>Additional commits viewable in <a href="https://github.com/vitejs/vite/commits/v4.4.10/packages/vite">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the react group with 1 update: [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 6.7.3 to 6.7.4 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v6.7.4</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v6.7.3...v6.7.4">6.7.4</a> (2023-10-02)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v6.7.3...v6.7.4">6.7.4</a> (2023-10-02)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/eslint-plugin</code></p> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d948dc4a21ad8e15eec152c0cf2fdda819ea4a3a"><code>d948dc4</code></a> chore: publish v6.7.4</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.4/packages/eslint-plugin">compare view</a></li> </ul> </details> <br /> Updates `@typescript-eslint/parser` from 6.7.3 to 6.7.4 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v6.7.4</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v6.7.3...v6.7.4">6.7.4</a> (2023-10-02)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v6.7.3...v6.7.4">6.7.4</a> (2023-10-02)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/parser</code></p> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d948dc4a21ad8e15eec152c0cf2fdda819ea4a3a"><code>d948dc4</code></a> chore: publish v6.7.4</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.4/packages/parser">compare view</a></li> </ul> </details> <br /> You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Albert <26584478+albertteoh@users.noreply.github.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Albert <26584478+albertteoh@users.noreply.github.com>
2 tasks
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Oct 4, 2023
## Description of the changes - Per discussion in https://github.com/jaegertracing/jaeger-ui/pull/1844/files#r1345598291, we'd like to reference the release notes in this repo from the jaeger-ui repo. - This PR makes some modifications needed for jaegertracing/jaeger-ui#1844. ## How was this change tested? - Used to generate the changelog in jaegertracing/jaeger-ui#1844. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits --------- Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
yurishkuro
reviewed
Oct 4, 2023
Makefile
Outdated
| @@ -0,0 +1,7 @@ | |||
| .PHONY: changelog | |||
| changelog: | |||
| ./scripts/release-notes.py --exclude-dependabot --repo jaeger-ui --point-markdown-char '-' | |||
There was a problem hiding this comment.
could we just curl/wget this from the main repo ?
https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/release-notes.py
There was a problem hiding this comment.
Yup, that's what I plan to do, just wanted to get your thoughts on whether we should do the same for ./scripts/draft-release.py as well before I make that change.
yurishkuro
reviewed
Oct 4, 2023
| @@ -32,3 +32,4 @@ coverage: | |||
| paths: null | |||
| ignore: | |||
| - "packages/jaeger-ui/src/utils/helpers/ReactShallowRenderer.js" | |||
| - "scripts" | |||
There was a problem hiding this comment.
I think you want .prettierignore, not codecov
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
…o release-v1.34.0
|
I seem to have buggered up the rebase, so I've created a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares Jaeger UI release v1.34.0