Prepare release v1.34.0 #1849
Merged
Prepare release v1.34.0 #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
yurishkuro
previously approved these changes
Oct 5, 2023
yurishkuro
reviewed
Oct 5, 2023
.prettierignore
Outdated
| packages/jaeger-ui/index.d.ts | ||
| scripts |
There was a problem hiding this comment.
I think the issue was not with scripts, but with the CHANGELOG that prettier was trying to change (switching between * and - for bullets)
There was a problem hiding this comment.
It's fine to ignore the downloaded scripts, but then I'd narrow it to
Suggested change
| scripts | |
| scripts/release-notes.py | |
| scripts/draft-release.py |
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
|
FYI, I've also deleted the get-changelog.js and get-tracking-version.js files as discussed. @yurishkuro PTAL |
2 tasks
yurishkuro
reviewed
Nov 23, 2023
| @@ -1,139 +0,0 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
@albertteoh did you delete this by mistake? It is used during the build
jaeger-ui/packages/jaeger-ui/package.json
Line 103 in f391b86
yurishkuro
added a commit
that referenced
this pull request
Nov 25, 2023
## Which problem is this PR solving? - Error during build ``` > jaeger-ui $ NODE_ENV=production REACT_APP_VSN_STATE=$(../../scripts/get-tracking-version.js) vite build /bin/sh: ../../scripts/get-tracking-version.js: No such file or directory ``` ## Description of the changes - Restore the file which may have been accidentally deleted in #1849 Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares Jaeger UI release v1.34.0.
Includes some quality of life improvements for my fellow maintainers:
Supersedes #1844.
Checklist