Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA event tracking for actions in trace view #191

Merged
merged 21 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@tiffon
Copy link
Member

commented Mar 1, 2018

Partially addresses #157.

Adds GA event tracking for trace view.

This adds events for:

  • Viewing time range
  • Filter set / clear
  • Open / close
    • The trace header
    • Parents
    • Span details
    • Tags, process, logs, log-items in span details
  • Resize the span-name column

Search and dependency graphs are outstanding and will likely be a different PR.

tiffon added some commits Feb 10, 2018

Track errors in GA w raven-js; TODO: tests, readme
Signed-off-by: Joe Farro <joef@uber.com>
Include CSS selector with last error breadcrumb
Signed-off-by: Joe Farro <joef@uber.com>
README for GA error tracking
Signed-off-by: Joe Farro <joef@uber.com>
Misc cleanup
Signed-off-by: Joe Farro <joef@uber.com>
README info on GA Application Tracking
Signed-off-by: Joe Farro <joef@uber.com>
Misc fix to tracking README
Signed-off-by: Joe Farro <joef@uber.com>
Misc cleanup to raven message conversion to GA
Signed-off-by: Joe Farro <joef@uber.com>
Tests for tracking
Signed-off-by: Joe Farro <joef@uber.com>
Apply prettier to markdown files
Signed-off-by: Joe Farro <joef@uber.com>
Error tracking fn name fallback, CSS import order
Signed-off-by: Joe Farro <joef@uber.com>
GA event tracking in trace view, tests are TODO
Signed-off-by: Joe Farro <joef@uber.com>
Fix broken tests
Signed-off-by: Joe Farro <joef@uber.com>
Tests for TracePage tracking
Signed-off-by: Joe Farro <joef@uber.com>

@tiffon tiffon requested review from yurishkuro and saminzadeh Mar 1, 2018

@ghost ghost assigned tiffon Mar 1, 2018

@ghost ghost added the review label Mar 1, 2018

@codecov

This comment has been minimized.

Copy link

commented Mar 1, 2018

Codecov Report

Merging #191 into master will decrease coverage by 0.06%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   89.15%   89.08%   -0.07%     
==========================================
  Files          98      104       +6     
  Lines        2222     2291      +69     
  Branches      460      466       +6     
==========================================
+ Hits         1981     2041      +60     
- Misses        203      211       +8     
- Partials       38       39       +1
Impacted Files Coverage Δ
...elineViewer/TimelineHeaderRow/TimelineHeaderRow.js 100% <ø> (ø) ⬆️
.../TracePage/TraceTimelineViewer/SpanDetail/index.js 100% <ø> (ø) ⬆️
src/index.js 0% <ø> (ø) ⬆️
src/components/TracePage/TracePageHeader.js 80% <ø> (ø) ⬆️
...aceTimelineViewer/SpanDetail/AccordianKeyValues.js 100% <ø> (ø) ⬆️
.../components/TracePage/TraceTimelineViewer/index.js 50% <ø> (ø) ⬆️
src/middlewares/index.js 63.63% <ø> (ø) ⬆️
src/components/TracePage/KeyboardShortcutsHelp.js 33.33% <0%> (ø) ⬆️
src/components/TracePage/index.js 94.89% <100%> (+0.27%) ⬆️
src/components/TracePage/SpanGraph/ViewingLayer.js 92.85% <100%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ee282...c9673fd. Read the comment docs.

@tiffon

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2018

@simonrobb Can you look this PR over when you get the chance?

Additional tests for trace GA event tracking
Signed-off-by: Joe Farro <joef@uber.com>
@simonrobb
Copy link

left a comment

Few minor nits.


const context = 'jaeger/ux/trace/kbd-modal';

export default function trackKbdHelpModal() {

This comment has been minimized.

Copy link
@simonrobb

simonrobb Mar 2, 2018

Given you're tracking an event maybe be more verbose with the event being tracked. Suggestion: trackKbdHelpModalOpen

This comment has been minimized.

Copy link
@tiffon

tiffon Mar 6, 2018

Author Member

👍

const altViewCtx = 'jaeger/ux/trace/alt-view';
export const slimHeaderCtx = 'jaeger/ux/trace/slim-header';

export function trackAltView() {

This comment has been minimized.

Copy link
@simonrobb

simonrobb Mar 2, 2018

Suggestion: trackAltViewOpen

This comment has been minimized.

Copy link
@tiffon

tiffon Mar 6, 2018

Author Member

👍

});
}

export function trackSlimHeader(isOpen: boolean) {

This comment has been minimized.

Copy link
@simonrobb

simonrobb Mar 2, 2018

Suggestion: trackSlimHeaderStateChange

This comment has been minimized.

Copy link
@tiffon

tiffon Mar 6, 2018

Author Member

👍

import JaegerUIApp from './components/App';
import { context as trackingContext } from './utils/tracking';

// these need to go after the App import

This comment has been minimized.

Copy link
@simonrobb

simonrobb Mar 2, 2018

Before or after?

This comment has been minimized.

Copy link
@tiffon

tiffon Mar 6, 2018

Author Member

Doh! Merge conflicts... Thanks!

tiffon added some commits Mar 6, 2018

Better names for tracking functions
Signed-off-by: Joe Farro <joef@uber.com>
Make GA event tracking more concise (PR feedback)
Signed-off-by: Joe Farro <joef@uber.com>
Revert the "more concise" changes
Signed-off-by: Joe Farro <joef@uber.com>

tiffon added some commits Mar 26, 2018

Merge branch 'master' into issue-157-enhanced-ga
Signed-off-by: Joe Farro <joef@uber.com>
Update changelog
Signed-off-by: Joe Farro <joef@uber.com>

@tiffon tiffon merged commit c622330 into master Mar 26, 2018

6 checks passed

DCO All commits have a DCO sign-off from the author
License Compliance License checks passed.
Details
codecov/patch 91.66% of diff hit (target 89.15%)
Details
codecov/project Absolute coverage decreased by -0.15% but relative coverage increased by +2.51% compared to 00ee282
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ghost ghost removed the review label Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.