Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting warnings for all no-unused-vars #1913

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix linting warnings for all no-unused-vars #1913

merged 2 commits into from
Oct 25, 2023

Conversation

DerenToy
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Unused variables have been removed

How was this change tested?

  • By running "yarn lint" command

Checklist

@DerenToy
Fix linting warnings for no-unused-vars
64f65b5 
Signed-off-by: deren.toy <derentoy@gmail.com>
@DerenToy DerenToy requested a review from a team as a code owner October 25, 2023 05:00
@DerenToy DerenToy requested review from joe-elliott and removed request for a team October 25, 2023 05:00
@DerenToy DerenToy mentioned this pull request Oct 25, 2023
Closed
4 tasks
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Oct 25, 2023
@yurishkuro yurishkuro changed the title Part:1 Fix linting warnings for all no-unused-vars Fix linting warnings for all no-unused-vars Oct 25, 2023
@DerenToy
Copy link
Contributor Author

@yurishkuro
I'm really sorry to bother you again, but I want to ask a question to make sure I don't do anything wrong. You had mentioned it's better for me to open new PRs to fix other eslint errors; is there any downside to creating different branches for each?

@yurishkuro yurishkuro merged commit 2cad413 into jaegertracing:main Oct 25, 2023
8 checks passed
@yurishkuro
Copy link
Member

Thank you!

@yurishkuro
Copy link
Member

is there any downside to creating different branches for each?

no, that's precisely what you'd have to do to create different PRs.

@DerenToy
Copy link
Contributor Author

Thank you so much for everything 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DerenToy @yurishkuro