Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to FAQ explaining why service map is empty #1963

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add link to FAQ explaining why service map is empty #1963

merged 1 commit into from
Nov 10, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add a link to FAQ that explains why service map can be empty.

How was this change tested?

image

@yurishkuro
Add link to FAQ explaining why service map is empty
1bf993a 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 10, 2023 15:49
@yurishkuro yurishkuro requested review from joe-elliott and removed request for a team November 10, 2023 15:49
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 10, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...jaeger-ui/src/components/DependencyGraph/index.jsx 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@yurishkuro yurishkuro enabled auto-merge (squash) November 10, 2023 17:41
jkowall
jkowall approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, thanks @yurishkuro

@yurishkuro yurishkuro merged commit 45d7fd0 into jaegertracing:main Nov 10, 2023
10 of 11 checks passed
@yurishkuro yurishkuro deleted the no-deps branch November 10, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall jkowall approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurishkuro @jkowall