Change Vite config from CJS to ESM

[ShivamMadlani]

This commit fixes the CJS deprication warning.

Which problem is this PR solving?

• Resolves Upgrade to ESM build of Vite #1985

Description of the changes

• Add type: module to package.json
• Imported visualizer as a function and used as a PluginOption

How was this change tested?

• yarn test

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

• are the *.mts files included in our linter?
• instead of renaming the file, why not add "type": "module" to ./packages/jaeger-ui/package.json?

[ShivamMadlani]

are the *.mts files included in our linter?

no they arent.. forgot to check that.

yeah you are right that would be better. making the change...

[ShivamMadlani]

hey @yurishkuro some tests are failing as they are using require() instead of import... i think this could be maybe resolved by using .cjs extension for tests in order to use require statements?? or we could rewrite the tests and use import statements instead...

[yurishkuro]

can you analyze how many changes would be needed? Fixing require would be my preferred path, but if it's too much work then perhaps just renaming vite config to .mts is a better fix (we'd need to include it in the linter globs)

[ShivamMadlani]

yup currently there are a total of 18 occurances of require in the project. changing around 11 of them located in the test folder should pass all the tests. however we could just change all the requires so the whole project gets cleaned up...waiting for your thumbsup

[ShivamMadlani]

@yurishkuro made the changes...tests should be able to pass now

[yurishkuro]

you can speed up the iterations by running the tests locally (yarn lint and yarn test) instead of waiting for me to approve the CI run

[ShivamMadlani]

hey @yurishkuro i think its best to rename vite.config to mts. changing imports to require is causing few tests to fail which required renaming a bunch of other files that uses CJS which would defeat the purpose of this issue.
however i also added .mts to our formatter and yarn tests are passing locally.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72106e4) 96.54% compared to head (75ad7d4) 96.54%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         256      256           
  Lines        7604     7604           
  Branches     1978     1978           
=======================================
  Hits         7341     7341           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

Thanks @ShivamMadlani