-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Vite config from CJS to ESM #1992
Merged
yurishkuro
merged 8 commits into
jaegertracing:main
from
ShivamMadlani:vite_ESM_upgrade
Nov 25, 2023
Merged
Change Vite config from CJS to ESM #1992
yurishkuro
merged 8 commits into
jaegertracing:main
from
ShivamMadlani:vite_ESM_upgrade
Nov 25, 2023
Commits on Nov 21, 2023
-
This commit fixes the CJS deprication warning. Signed-off-by: shivam <shivammadlani5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0131080 - Browse repository at this point
Copy the full SHA 0131080View commit details
Commits on Nov 22, 2023
-
This commit fixes the CJS deprication warning Signed-off-by: shivam <shivammadlani5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5559770 - Browse repository at this point
Copy the full SHA 5559770View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6cce70 - Browse repository at this point
Copy the full SHA f6cce70View commit details
Commits on Nov 23, 2023
-
The previous commit changed the config from CJS to ESM which caused 2 tests to fail. This commit fixes the above issue by replacing 'require' with 'import' throughout the project Signed-off-by: shivam <shivammadlani5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d774447 - Browse repository at this point
Copy the full SHA d774447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c18c4b - Browse repository at this point
Copy the full SHA 4c18c4bView commit details -
Merge branch 'vite_ESM_upgrade' of https://github.com/ShivamMadlani/j…
…aeger-ui into vite_ESM_upgrade
Configuration menu - View commit details
-
Copy full SHA for ab5dc75 - Browse repository at this point
Copy the full SHA ab5dc75View commit details
Commits on Nov 25, 2023
-
This commit fixes the CJS deprication warning by renaming vite.config.ts to vite.config.mts. Signed-off-by: shivam <shivammadlani5@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e28f297 - Browse repository at this point
Copy the full SHA e28f297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75ad7d4 - Browse repository at this point
Copy the full SHA 75ad7d4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.