Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore scripts/get-tracking-version.js deleted by accident #1998

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 23, 2023

Which problem is this PR solving?

  • Error during build
> jaeger-ui
$ NODE_ENV=production REACT_APP_VSN_STATE=$(../../scripts/get-tracking-version.js) vite build
/bin/sh: ../../scripts/get-tracking-version.js: No such file or directory

Description of the changes

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 23, 2023 00:41
@yurishkuro yurishkuro requested review from joe-elliott and removed request for a team November 23, 2023 00:41
@yurishkuro yurishkuro mentioned this pull request Nov 23, 2023
2 tasks
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa32e90) 96.54% compared to head (6365144) 96.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         256      256           
  Lines        7604     7604           
  Branches     1978     1978           
=======================================
  Hits         7341     7341           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 23, 2023
@yurishkuro yurishkuro requested review from albertteoh and removed request for joe-elliott November 23, 2023 00:52
@yurishkuro yurishkuro merged commit 72106e4 into jaegertracing:main Nov 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants