Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exact phrase search syntax #2028

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

kshmidt-digma
Copy link
Contributor

Use double quote sign to search for queries with whitespaces
Signed-off-by: Kyrylo Shmidt kshmidt@digma.ai

Which problem is this PR solving?

Description of the changes

  • Split the search query string by whitespace, but not that in double quotes

How was this change tested?

  • By updating the unit tests

Checklist

Use double quote sign to search for queries with whitespaces
Signed-off-by: Kyrylo Shmidt <kshmidt@digma.ai>
@kshmidt-digma kshmidt-digma requested a review from a team as a code owner December 6, 2023 07:02
@kshmidt-digma kshmidt-digma requested review from jkowall and removed request for a team December 6, 2023 07:02
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08ee957) 96.55% compared to head (eeed0d0) 96.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2028   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         256      256           
  Lines        7625     7627    +2     
  Branches     1982     1983    +1     
=======================================
+ Hits         7362     7364    +2     
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:new-feature Change that should be called out as new feature in CHANGELOG label Dec 6, 2023
@yurishkuro yurishkuro merged commit 4791312 into jaegertracing:main Dec 6, 2023
9 of 10 checks passed
@yurishkuro
Copy link
Member

Thanks!

@kshmidt-digma kshmidt-digma deleted the feature/exact-phrase-search branch December 7, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:new-feature Change that should be called out as new feature in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add exact phrase search
2 participants