fix: Fix some linting warnings #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 255 255
Lines 7622 7622
Branches 1985 1983 -2
=======================================
Hits 7360 7360
Misses 262 262 ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:ci
yurishkuro
reviewed
Dec 24, 2023
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
EshaanAgg
added a commit
to EshaanAgg/jaeger-ui
that referenced
this pull request
Dec 24, 2023
## Which problem is this PR solving? Fixes part of jaegertracing#1608 ## Description of the changes - Added the minimal types needed to fix the linting warnings - Replaced `{}` with the `object` type ## How was this change tested? - Ran `yarn lint` locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes part of #1608
Description of the changes
{}with theobjecttypeHow was this change tested?
yarn lintlocallyChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test