-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix some linting warnings #2064
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2064 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 255 255
Lines 7622 7622
Branches 1985 1983 -2
=======================================
Hits 7360 7360
Misses 262 262 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!
packages/jaeger-ui/src/components/SearchTracePage/SearchForm.track.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## Which problem is this PR solving? Fixes part of jaegertracing#1608 ## Description of the changes - Added the minimal types needed to fix the linting warnings - Replaced `{}` with the `object` type ## How was this change tested? - Ran `yarn lint` locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Which problem is this PR solving?
Fixes part of #1608
Description of the changes
{}
with theobject
typeHow was this change tested?
yarn lint
locallyChecklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test