Fix upload file into search page unnecessary POST #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
yurishkuro
reviewed
Mar 5, 2024
| } | ||
| beforeUpload={(file, fileList) => { | ||
| fileList.forEach(fileFromList => props.loadJsonTraces({ file: fileFromList })); | ||
| return false; |
There was a problem hiding this comment.
this is the change, right? Could you point to documentation that explains it?
There was a problem hiding this comment.
https://ant.design/components/upload
beforeUpload: Hook function which will be executed before uploading. Uploading will be stopped with false or a rejected Promise returned.
Set it to always return false, and it won't POST.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 254 254
Lines 7639 7641 +2
Branches 1927 1992 +65
=======================================
+ Hits 7379 7381 +2
Misses 260 260 ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:bugfix-or-minor-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Manually tested.
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test