Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add depcheck 1.4.7 in package.json #2202

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

tico88612
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Add depcheck 1.4.7 in package.json
  • Remove add global depcheck in CI test

How was this change tested?

  • manual test

Checklist

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 requested a review from a team as a code owner March 9, 2024 02:41
@tico88612 tico88612 requested review from jkowall and removed request for a team March 9, 2024 02:41
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (f704b56) to head (86fd09a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2202   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         254      254           
  Lines        7639     7641    +2     
  Branches     1927     1990   +63     
=======================================
+ Hits         7379     7381    +2     
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

run: |
yarn global add depcheck
yarn run depcheck
run: yarn run depcheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can drop the name and just do - run as the other commands

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Mar 9, 2024
@yurishkuro yurishkuro merged commit d47648a into jaegertracing:main Mar 9, 2024
8 of 9 checks passed
@yurishkuro
Copy link
Member

Thanks!

@tico88612 tico88612 deleted the feat/depcheck-in-yarnlock branch March 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: depcheck incorrectly flags dependencies as unused
2 participants