Improve trace page title with data and unique emoji (fixes #2256) #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Apr 23, 2024
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.tsx
Outdated
Show resolved
Hide resolved
nox
force-pushed
the
titles
branch
3 times, most recently
from
ce3e732
to
bda5c09
Compare
yurishkuro
reviewed
Apr 23, 2024
yurishkuro
added
the
changelog:new-feature
yurishkuro
reviewed
Apr 24, 2024
packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.tsx
Show resolved
Hide resolved
nox
force-pushed
the
titles
branch
4 times, most recently
from
f65c4ff
to
4bcc015
Compare
nox
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2275 +/- ##
=======================================
Coverage 96.59% 96.60%
=======================================
Files 254 254
Lines 7641 7662 +21
Branches 1990 1931 -59
=======================================
+ Hits 7381 7402 +21
Misses 260 260 ☔ View full report in Codecov by Sentry. |
nox
force-pushed
the
titles
branch
2 times, most recently
from
2d46e31
to
547663d
Compare
yurishkuro
added
changelog:bugfix-or-minor-feature
nox
force-pushed
the
titles
branch
2 times, most recently
from
cad096d
to
03fe1a8
Compare
It is already provided to the component through the traceName prop. Signed-off-by: Anthony Ramine <nox@nox.paris>
Signed-off-by: Anthony Ramine <nox@nox.paris>
We make trace pages have a title "<trace short ID>: <operation name> (<service name>)" to improve navigation when the user has many traces open in their browser. Signed-off-by: Anthony Ramine <nox@nox.paris>
> Dear colleague, are you talking about the shrimp trace or the baguette trace? To help discussing about traces with coworkers when debugging issues, referring to a unique and distinguishable emoji is good. Signed-off-by: Anthony Ramine <nox@nox.paris>
yurishkuro
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
<unique emoji> <short trace id>: <operation name> (<service name>) — Jaeger UI.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test